Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve grant handling for space members #2620

Merged
merged 1 commit into from
Mar 7, 2022
Merged

improve grant handling for space members #2620

merged 1 commit into from
Mar 7, 2022

Conversation

micbar
Copy link
Member

@micbar micbar commented Mar 7, 2022 •
edited
Loading

Description

Improve the grant handling

@micbar micbar requested review from labkode, ishank011, glpatcern and a team as code owners March 7, 2022 08:59
@micbar micbar requested review from C0rby and kobergj March 7, 2022 08:59
kobergj
kobergj requested changes Mar 7, 2022
View reviewed changes
Copy link
Contributor

@kobergj kobergj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG 👍 Just some minors

internal/grpc/services/gateway/usershareprovider.go Outdated Show resolved Hide resolved
internal/grpc/services/gateway/usershareprovider.go Outdated Show resolved Hide resolved
@micbar micbar requested a review from kobergj March 7, 2022 10:31
@micbar micbar merged commit b5c0944 into cs3org:edge Mar 7, 2022
@kobergj kobergj mentioned this pull request Oct 14, 2022
Merged
@kiranparajuli589 kiranparajuli589 mentioned this pull request Oct 20, 2022
Merged
@kiranparajuli589 kiranparajuli589 mentioned this pull request Oct 28, 2022
Merged
@kobergj kobergj mentioned this pull request Dec 19, 2022
Merged
@kobergj kobergj mentioned this pull request May 22, 2023
Closed
@kobergj kobergj mentioned this pull request Mar 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kobergj kobergj kobergj approved these changes

@labkode labkode Awaiting requested review from labkode labkode is a code owner

@ishank011 ishank011 Awaiting requested review from ishank011

@glpatcern glpatcern Awaiting requested review from glpatcern glpatcern is a code owner

@C0rby C0rby Awaiting requested review from C0rby

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@micbar @kobergj